feat: imports hardforks preset accounts #805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyeshe
force-pushed
the
hardfork-preset-accounts
branch
from
12b87bb
to
ffeab9b
Compare
|
README notes to be added... |
sborrazas
requested changes
Jul 26, 2022
| """ | ||
| @spec import_account_presets() :: :ok | ||
| def import_account_presets do | ||
| case Database.next_key(Model.KindIntTransferTx, {"accounts_lima", {-1, -1}, <<>>, -1}) do |
There was a problem hiding this comment.
Can we turn this entirely into a mutation? That way we continue encapsulating Database calls through the State
There was a problem hiding this comment.
The Database is used because the goal is to check if the data is already persisted.
There was a problem hiding this comment.
I understand that's what it does. I was suggesting changing how it does it. It's optional anyway, feel free to merge it
There was a problem hiding this comment.
I am talking about how not to encapsulate things to make the purpose clearer.
sborrazas
approved these changes
Jul 27, 2022
jyeshe
force-pushed
the
hardfork-preset-accounts
branch
from
4c1b96e
to
ba97eef
Compare
jyeshe
force-pushed
the
hardfork-preset-accounts
branch
from
ba97eef
to
b6effb0
Compare
thepiwo
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #347