fix: broadcast in-memory blocks #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepiwo
approved these changes
Jul 28, 2022
jyeshe
reviewed
Jul 29, 2022
| defp push_hash(%__MODULE__{dispatched_hashes: dispatched_hashes}, type_hash) do | ||
| queue = :queue.in(type_hash, dispatched_hashes) | ||
|
|
||
| if length(:queue.to_list(queue)) > @max_hashes_size do |
There was a problem hiding this comment.
Could you increase this number please? The counting I am doing is 10 generations (max of sync Server), 20 microblocks and more than 50 transactions each.
There was a problem hiding this comment.
Or maybe use some kind of TTL to remove the older ones.
There was a problem hiding this comment.
Moved to ETS for the TTL expiring. thanks!
jyeshe
reviewed
Jul 30, 2022
| @subs_target_channels :subs_target_channels | ||
|
|
||
| @spec start_link(any()) :: GenServer.on_start() | ||
| def start_link(_arg), do: GenServer.start_link(__MODULE__, :ok, name: __MODULE__) | ||
|
|
||
| @impl GenServer | ||
| def init(:ok) do | ||
| {:ok, @no_state} | ||
| EtsCache.new(@hashes_table, @expiration_minutes) |
There was a problem hiding this comment.
One last thing, I would move the creation of this named ETS to outside the GenServer init in case it restarts.
jyeshe
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This state check will avoid sending the same mb/kb multiple times, which happens when re-syncing in-memory gens.
refs #808