feat: add /key-blocks/:hash_or_kbi/micro-blocks endpoint #896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jyeshe
reviewed
Sep 8, 2022
Comment on lines
+168
to
+170
| with_mocks [ | ||
| {:aec_chain, [], [get_block: fn ^decoded_hash -> :error end]} | ||
| ] do |
There was a problem hiding this comment.
It's needed because the fetch_key_block_micro_blocks function will check for the hash existing by using :aec_chain.get_block(kb_hash)
lib/ae_mdw/blocks.ex
Outdated
| {{height, 0}, {height, Util.max_256bit_int()}}, | ||
| cursor | ||
| ) | ||
| |> Stream.take_while(&match?({^height, _mbi}, &1)) |
There was a problem hiding this comment.
key boundary should cover this match
jyeshe
approved these changes
Sep 8, 2022
sborrazas
force-pushed
the
micro-blocks-v2
branch
from
5e6a387
to
f960765
Compare
thepiwo
approved these changes
Sep 12, 2022
sborrazas
force-pushed
the
micro-blocks-v2
branch
from
f960765
to
fba3ab6
Compare
thepiwo
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #888
requires #895 to be merged first