Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: include internal transactions as activities #911

Merged
merged 4 commits into from
Sep 26, 2022
Merged

feat: include internal transactions as activities #911

merged 4 commits into from
Sep 26, 2022

Conversation

sborrazas
Copy link
Contributor

@sborrazas sborrazas commented Sep 22, 2022 •
edited
Loading

refs #725

@sborrazas sborrazas self-assigned this Sep 22, 2022
jyeshe
jyeshe reviewed Sep 22, 2022
View reviewed changes
Copy link
Member

@jyeshe jyeshe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some refactoring opportunities. For the deduplication, the question would be if a contract id used to search GrpIntContractCall could also appear in the IdIntContractCall?

lib/ae_mdw/activities.ex Outdated Show resolved Hide resolved
lib/ae_mdw/activities.ex Show resolved Hide resolved
lib/ae_mdw/activities.ex Outdated Show resolved Hide resolved
lib/ae_mdw/fields.ex Outdated Show resolved Hide resolved
@jyeshe jyeshe self-requested a review September 23, 2022 09:25
thepiwo
thepiwo reviewed Sep 23, 2022
View reviewed changes
README.md
"contract_id": "ct_2AfnEfCSZCTEkxL5Yoi4Yfq6fF7YapHRaFKDJK3THMXMBspp5z",
"contract_tx_hash": "th_6memqAr5S3UQp1pc4FWXT8xUotfdrdUFgBd8VPmjM2ZRuojTF",
"contract_txi": 8392766,
"function": "Oracle.query",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

each IntContractCallEvent has the function attribute, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct

README.md Outdated
"local_idx": 3,
"micro_index": 0
},
"type": "IntContractCallEvent"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use full name "Internal.."

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't seem to be adjusted in docs

thepiwo
thepiwo approved these changes Sep 25, 2022
View reviewed changes
README.md Outdated
"local_idx": 3,
"micro_index": 0
},
"type": "IntContractCallEvent"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't seem to be adjusted in docs

@sborrazas sborrazas merged commit 5ab2cb2 into master Sep 26, 2022
@sborrazas sborrazas deleted the int-activities branch September 26, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thepiwo thepiwo thepiwo approved these changes

@jyeshe jyeshe jyeshe approved these changes

Assignees

@sborrazas sborrazas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sborrazas @thepiwo @jyeshe