-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compatibility with create-react-app@4 #1529
Comments
Azure/azure-sdk-for-js#22172 |
let's just drop out of the box compatibility with |
I think the react application is now working with latest SDK release where the circular dependency was removed. tested https://github.com/subhod-i/aepp-boilerplate-react today. I talked to @ifaouibadi to revisit this and provide a PR to the "official" react boilerplate repo of Emmanuel once reay |
the problem is not in circular dependencies (we had it before), but in imports of cjs modules from mjs in |
@ifaouibadi is this a blocker / problem for the boilerplate right now? |
@marc0olo it works fine, btw after the update the boilerplate uses |
Recently I find out that api generated by
autorest
can't be build in create-react-app@4 with error:node.mjs contains
As a workaround I made a patch https://github.com/aeternity/babel-plugin-transform-default-named-imports/commit/a4a149b1473114dacc29ec939d98bfa388117e88 to babel-plugin-transform-default-named-imports that rewrites it to:
The oridinal issue probably because azure packages doesn't formatted properly to work in this case (have mjs file extension or
type: module
in package.json).Also, would be nice if
babel-plugin-transform-default-named-imports
supports rewriting a namespace import to a default one (as I implemented in my patch).I'm asking @subhod-i to investigate this and to send a PR to the babel plugin and to open an issue in one of autorest repos.
The text was updated successfully, but these errors were encountered: