fix: name activation price label in dashboard #356
Conversation
lukeromanowicz
requested review from
michele-franchi,
janmichek and
CharisSiarampalis
src/utils/adapters.js
Outdated
| ? formatAettosToAe(chainName.last_bid.tx.name_fee) | ||
| : formatAettosToAe(chainName.info.claims[chainName.info.claims.length - 1].tx.name_fee), | ||
| isAuction: isAuction(chainName.name), | ||
| price: formatAettosToAe(chainName.info.claims[chainName.info.claims.length - 1].tx.name_fee), |
There was a problem hiding this comment.
Apparently there was some change in the mdw since we implemented this code and this code can be used to get the price for both auctioned name and a direct buy
There was a problem hiding this comment.
Have you tried this? Its a new addition to JS https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/at
|
Deployed to https://pr-356-aescan.stg.aepps.com |
|
@lukeromanowicz I think "Auction" is sufficient as label |
|
@marc0olo roger that, adjusted 👍 |
src/utils/adapters.js
Outdated
| ? formatAettosToAe(chainName.last_bid.tx.name_fee) | ||
| : formatAettosToAe(chainName.info.claims[chainName.info.claims.length - 1].tx.name_fee), | ||
| isAuction: isAuction(chainName.name), | ||
| price: formatAettosToAe(chainName.info.claims[chainName.info.claims.length - 1].tx.name_fee), |
There was a problem hiding this comment.
Have you tried this? Its a new addition to JS https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/at
|
@janmichek love it, thank you! I haven't seen that before |
Cool, yea its a new thing |
|
Are PR preview links broken? |
Description
Resolves #328
Demo
Checklist: