Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Keyblock details hints #381

Merged
merged 16 commits into from
Jul 26, 2023
Merged

feat: Keyblock details hints #381

merged 16 commits into from
Jul 26, 2023

Conversation

janmichek
Copy link
Collaborator

Description

resolves #372

Demo

firefox_46PXHCQ5vn.mp4

Checklist:

@github-actions
Copy link

Deployed to https://pr-381-aescan.stg.aepps.com

Copy link
Contributor

@lukeromanowicz lukeromanowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job. I left a proposal and one note but overall looks good. I'm approving in advance

src/components/BlockchainPanel.vue Show resolved Hide resolved
src/utils/hints/keyblocksHints.js Outdated Show resolved Hide resolved
@janmichek janmichek requested a review from marc0olo July 20, 2023 10:30
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please have a look at my comments

src/utils/hints/keyblocksHints.js Outdated Show resolved Hide resolved
src/utils/hints/keyblocksHints.js Outdated Show resolved Hide resolved
@janmichek janmichek merged commit 7afbca7 into develop Jul 26, 2023
2 checks passed
@janmichek janmichek deleted the Keyblock_details_hints branch July 26, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyblock details hints
4 participants