Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: search by microblock and keyblock ids #384

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

lukeromanowicz
Copy link
Contributor

@lukeromanowicz lukeromanowicz commented Jul 18, 2023

Description

Resolves #368

I decided to prioritize searching numeric names over keyblocks because there is only a handful of names. Please let me know if that's the correct prioritization

Demo

2023-07-19.10-20-41.mp4

Checklist:

  • I have read and followed the Contributing Guide
  • My change does not require a change to the documentation.

@github-actions
Copy link

Deployed to https://pr-384-aescan.stg.aepps.com

Copy link
Collaborator

@janmichek janmichek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done, works good 🥇

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

@lukeromanowicz lukeromanowicz merged commit a203760 into develop Jul 21, 2023
3 checks passed
@lukeromanowicz lukeromanowicz deleted the feat/search-by-microblock-and-keyblock branch July 21, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search by keyblock id and microblock id
4 participants