-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement switching to next/previous block on detail pages #395
feat: Implement switching to next/previous block on detail pages #395
Conversation
Deployed to https://pr-395-aescan.stg.aepps.com |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good but is there a way to disable the next arrow if the keyblock is the last one to avoid the "Requested keyblock has never been seen in the network." screen?
I think it should be doable by checking height against blockHeight in recentBlocksStore |
Fixed and regenerated the demo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expected that more recent keyblock button will be on the left side since every content we display is always latest first, and older stuff is available when you navigate right. But I guess this works too, just a little bit unexpected.
Overall very good job, I left only one not but I'm afraid it needs to be fixed before merging
'keyblock-details-panel__button', | ||
'keyblock-details-panel__button--next', | ||
]" | ||
:disabled="!isNextKeyblockMined"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the button is still clickable, even if it's disabled :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. You are right, haven't spotted this. Fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now it works great, thank you for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works great!
Could you please open a followup to improve arrows handling and enable again the next one if a new keyblock comes from the websocket? Not super needed right now but this would improve it.
Description
resolves #375
fixes #406
compared to the visual material, the design is old for consistency and will be improved here #148
Demo
firefox_pMVLrk9NPG.mp4
Checklist: