feat: account tokens #450
Merged
feat: account tokens #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deployed to https://pr-450-aescan.stg.aepps.com |
lukeromanowicz
commented
Aug 16, 2023
| @@ -40,7 +40,7 @@ export function formatAePrice(price, maxDigits = 8) { | |||
| decimals = decimals?.replace(/0+$/, '') | |||
|
|
|||
| if (!decimals) { | |||
| return integers === '0' ? `~${integers} AE` : `${formatNumber(integers)} AE` | |||
| return integers === '0' && decimals !== '' ? `~${integers} AE` : `${formatNumber(integers)} AE` | |||
There was a problem hiding this comment.
Otherwise, 0 is rendered as ~0
michele-franchi
requested changes
Aug 17, 2023
janmichek
approved these changes
Aug 17, 2023
janmichek
reviewed
Aug 17, 2023
janmichek
reviewed
Aug 17, 2023
michele-franchi
approved these changes
Aug 17, 2023
|
@Liubov-crypto please take a look at this one at your convenience |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #62
Demo
2023-08-16.09-53-11.mp4
Checklist: