-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Move time calculation to MDW #489
Conversation
Deployed to https://pr-489-aescan.stg.aepps.com |
:to="`/keyblocks/${channel.updatedHeight}`"> | ||
{{ channel.updatedHeight }} | ||
:to="`/keyblocks/${channel.lastUpdatedHeight}`"> | ||
{{ channel.lastUpdatedHeight }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanup for consistency
@@ -42,7 +39,7 @@ export const useOracleDetailsStore = defineStore('oracleDetails', () => { | |||
} | |||
|
|||
async function fetchOracle() { | |||
const { data } = await axios.get(`${MIDDLEWARE_URL}/v2/oracles/${oracleId.value}`) | |||
const { data } = await axios.get(`${MIDDLEWARE_URL}/v2/oracles/${oracleId.value}?tx_hash=true`) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as advised in here aeternity/ae_mdw#1425 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I think we should involve @Liubov-crypto to help us carefully test if there are no regressions
@Liubov-crypto please help us to test. The pages needs to be checked you will know by
Thank you |
@janmichek There is a partly translation time related data on some pages in Chrome browser, however I haven't applied it. Is this acceptable? |
It's a open topic we will solve later. I think this was the same before the change, right? Could you check? |
@janmichek yes, I see the same on the main branch. |
Description
partly #114
Demo
Checklist: