Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Move time calculation to MDW #489

Merged
merged 8 commits into from
Oct 23, 2023
Merged

Conversation

janmichek
Copy link
Collaborator

@janmichek janmichek commented Aug 31, 2023

Description

partly #114

Demo

Checklist:

@github-actions
Copy link

Deployed to https://pr-489-aescan.stg.aepps.com

:to="`/keyblocks/${channel.updatedHeight}`">
{{ channel.updatedHeight }}
:to="`/keyblocks/${channel.lastUpdatedHeight}`">
{{ channel.lastUpdatedHeight }}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup for consistency

@@ -42,7 +39,7 @@ export const useOracleDetailsStore = defineStore('oracleDetails', () => {
}

async function fetchOracle() {
const { data } = await axios.get(`${MIDDLEWARE_URL}/v2/oracles/${oracleId.value}`)
const { data } = await axios.get(`${MIDDLEWARE_URL}/v2/oracles/${oracleId.value}?tx_hash=true`)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as advised in here aeternity/ae_mdw#1425 (comment)

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 👏

Copy link
Contributor

@lukeromanowicz lukeromanowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think we should involve @Liubov-crypto to help us carefully test if there are no regressions

@janmichek
Copy link
Collaborator Author

@Liubov-crypto please help us to test. The pages needs to be checked you will know by

  • you go by looking at changes in adapters.js
  • it should be nicely named so eg adaptStateChannelDetails stands for state channels details.
  • check the affected pages, there should be all values present. Especially this datetime ones.

Thank you

@Liubov-crypto
Copy link
Collaborator

Liubov-crypto commented Oct 5, 2023

@janmichek There is a partly translation time related data on some pages in Chrome browser, however I haven't applied it. Is this acceptable?
auc
nam
or1
orac

@janmichek
Copy link
Collaborator Author

@janmichek There is a partly translation time related data on some pages in Chrome browser, however I haven't applied it. Is this acceptable? auc nam or1 orac

It's a open topic we will solve later. I think this was the same before the change, right? Could you check?

@Liubov-crypto
Copy link
Collaborator

@janmichek yes, I see the same on the main branch.

@janmichek janmichek merged commit bc2d7bd into develop Oct 23, 2023
2 checks passed
@janmichek janmichek deleted the Move-time-calculation-to-MDW branch October 23, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants