Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: better title handling #490

Merged
merged 6 commits into from
Sep 5, 2023
Merged

Conversation

lukeromanowicz
Copy link
Contributor

@lukeromanowicz lukeromanowicz commented Sep 1, 2023

Description

Resolves #414

Demo

No visual changes, just refactoring of page titles implementation. They should work just like before

Checklist:

  • I have read and followed the Contributing Guide
  • My change does not require a change to the documentation.

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

Deployed to https://pr-490-aescan.stg.aepps.com

Copy link
Collaborator

@janmichek janmichek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! 🍰 Exactly what I proposed.
Giving just a minor code suggestion if you like it

src/app.vue Outdated Show resolved Hide resolved
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

src/pages/keyblocks/[id].vue Outdated Show resolved Hide resolved
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
@lukeromanowicz lukeromanowicz merged commit 54f9fc7 into develop Sep 5, 2023
2 checks passed
@lukeromanowicz lukeromanowicz deleted the feat/better-title-handling branch September 5, 2023 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make page title dynamic
4 participants