feat: Nft details transfers tab 2 #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
2 tasks
janmichek
requested review from
lukeromanowicz and
michele-franchi
and removed request for
michele-franchi
|
Deployed to https://pr-494-aescan.stg.aepps.com |
lukeromanowicz
suggested changes
Sep 5, 2023
src/components/NftTransfersPanel.vue
Outdated
| await fetchNftTransfers({ queryParameters: nftTransfers.value.next }) | ||
| } | ||
|
|
||
| await fetchNftTransfers({ |
There was a problem hiding this comment.
I believe this should be executed on client side only due to using a window-dependent limit
There was a problem hiding this comment.
that's right, boss. Fixed
src/components/NftDetailsPanel.vue
Outdated
| @@ -104,6 +104,7 @@ | |||
| </template> | |||
|
|
|||
| <script setup> | |||
|
|
|||
There was a problem hiding this comment.
Most of our files don't use that additional newline after <script setup> Is there a reason for this sudden change?
michele-franchi
requested changes
Sep 5, 2023
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
michele-franchi
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixes #147
Demo
ct_2tw26RwgNADrpuCnrQWKPBH87bPxuRbLR1KLccS9ZJTUMMj4z8Checklist: