feat: Implement oracles filtering #520
Conversation
| @@ -55,12 +55,12 @@ async function loadNextTransactions() { | |||
| await fetchTransactions(transactions.value.next) | |||
| } | |||
|
|
|||
| const loadTransactions = () => { | |||
| async function loadTransactions() { | |||
There was a problem hiding this comment.
Unrelated to issue. consistency fixes in this file
janmichek
requested review from
lukeromanowicz and
michele-franchi
and removed request for
lukeromanowicz
|
Deployed to https://pr-520-aescan.stg.aepps.com |
There was a problem hiding this comment.
Filtering is working good.
But I have a question: It seems to me that order is broken here, correct me if I'm wrong:
https://github.com/aeternity/aescan/assets/69896204/9de12a19-3dab-4ecc-99be-0ecc80647606
or it is sorted by Expiration date and not by Registered? or sorting by the date isn't implemented yet?
|
LGTM |
There was a problem hiding this comment.
There seems to be an issue with history / navigation.
If you navigate to the oracles page and select "Inactive" in the filter and then go back you are redirected to "/oracles?state=active" and if you go back again you are redirected to "/oracles".
Could you check it?
Fixed |
Description
resolves #160
Demo
firefox_c2dP4jc59c.mp4
Checklist: