Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEX Trades General #532

Open
janmichek opened this issue Oct 17, 2023 · 6 comments · May be fixed by #840
Open

DEX Trades General #532

janmichek opened this issue Oct 17, 2023 · 6 comments · May be fixed by #840
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@janmichek
Copy link
Collaborator

janmichek commented Oct 17, 2023

Acceptance criteria:

  • A new page called "DEX Tracker" is displayed under the "Tokens" menu
  • The page contains a paginated table with the following columns:
    • Hash
    • Executed
    • Action: Sell | Buy | Swap
    • Token Amount (Out)
    • Token Amount (In)
    • Swapped Rate
    • Value: expressed in dollars
  • The action column has the following colours:
    • Buy: green
    • Sell: red
    • Swap: body colour
  • Each column of the table contains tooltip with proper descriptions

MDW dependency tracking: aeternity/ae_mdw#1611

@janmichek janmichek added enhancement New feature or request waiting for mdw Waiting for middleware release to unlock it labels Oct 17, 2023
@michele-franchi
Copy link
Collaborator

@janmichek to check if this feature is ready on mdw

@janmichek
Copy link
Collaborator Author

pinged again

@janmichek
Copy link
Collaborator Author

Not developed yet, still waiting

@michele-franchi michele-franchi changed the title Dex Trades General DEX Trades General Dec 20, 2023
@michele-franchi michele-franchi added this to the Q2 milestone Mar 27, 2024
@sborrazas
Copy link

It looks like there are a bunch of PRs created on November 2023 listed on that issue, can you check if this is what was needed?

@janmichek
Copy link
Collaborator Author

I don't see any output or documented endpoint I could check. The work was not handed over in any way to us.
Still look like work in progress to me

@janmichek janmichek removed the waiting for mdw Waiting for middleware release to unlock it label Jun 12, 2024
@janmichek janmichek linked a pull request Jun 13, 2024 that will close this issue
3 tasks
@janmichek
Copy link
Collaborator Author

Feature cannot be accomplished as plenty of data is missing in the response to compose table meaningful to user.
I tried the workaround for the feature before resolving but middle ware, but it would be too complex.

MDW tracking here
aeternity/ae_mdw#1815

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants