Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show hint if AENS name is in revoked state 2 #609

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

janmichek
Copy link
Collaborator

Description

resolves #454

Demo

firefox_51Lk8cgK46.mp4

Checklist:

Copy link

Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if I click on Next button to see other expires names the page becomes uploading status forever. The same issue is on product.

2023-12-11.4.42.00.mov

unc

I found additional issue on product, when I click on next button to see other In-auction names the previous button becomes unavailable. But maybe this is middleware issue?
if not, I will register it separately.

2023-12-11.4.46.37.mov

@janmichek please check it.

@janmichek
Copy link
Collaborator Author

if I click on Next button to see other expires names the page becomes uploading status forever. The same issue is on product.
2023-12-11.4.42.00.mov

unc

Hmm, interesting. I tried the same scenario without any probs. Maye there was some server downtime at that moment? Can I ask you to try again today?

I found additional issue on product, when I click on next button to see other In-auction names the previous button becomes unavailable. But maybe this is middleware issue? if not, I will register it separately.
2023-12-11.4.46.37.mov

@janmichek please check it.

Yes, I confirm this issue. WIll solve it separately. Good finding, thanks

@Liubov-crypto
Copy link
Collaborator

@janmichek I have a question: I can see some names in both tabs - Expired and In Auction, for example 77.chain and public.chain. Is this expected?

@Liubov-crypto
Copy link
Collaborator

2023-12-12.5.05.14.mov

@janmichek
Copy link
Collaborator Author

Thanks, should not be like that. I will check and possibly fix

@janmichek janmichek mentioned this pull request Dec 14, 2023
1 task
@janmichek
Copy link
Collaborator Author

2023-12-12.5.05.14.mov

Followup #621

@janmichek janmichek requested review from Liubov-crypto and removed request for Liubov-crypto December 15, 2023 13:52
Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, except the issues that I found and they should be fixed separately.

Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@janmichek janmichek merged commit 3df75d5 into develop Dec 20, 2023
4 of 6 checks passed
@janmichek janmichek deleted the show-hint-if-AENS-name-is-in-revoked-state branch December 20, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show hint if AENS name is in revoked state
3 participants