Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Warning about MDW out of sync #684

Merged
merged 4 commits into from
Mar 28, 2024
Merged

feat: Warning about MDW out of sync #684

merged 4 commits into from
Mar 28, 2024

Conversation

janmichek
Copy link
Collaborator

Description

resolves #605

Demo

image

image

Checklist:

@github-actions GitHub Actions
Copy link

Deployed to https://pr-684-aescan.stg.service.aepps.com and https://pr-684-aescan-testnet.stg.service.aepps.com

Liubov-crypto
Liubov-crypto suggested changes Mar 18, 2024
View reviewed changes
Copy link
Collaborator

@Liubov-crypto Liubov-crypto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got periodically 404 errors in FF, Chrome and Safari browsers.

Also I got these issues:

2024-03-18.5.19.30.mov

errr1
cons

@janmichek
Copy link
Collaborator Author

I got periodically 404 errors in FF, Chrome and Safari browsers.

Also I got these issues:
2024-03-18.5.19.30.mov

errr1 cons

I think it was caused by the deployment low resources. Can you retry now? However I am not sure how to test this, as wee need to have MDW in syncing state.

@Liubov-crypto
Copy link
Collaborator

It was not working for me in the testnet.
In mainnet I didn't get such issues as before.
Probably you have a right, I have to catch somehow middleware out of sync to test it properly. I tried to change my network settings, but it seems to be different and it requires another approach.

michele-franchi
michele-franchi requested changes Mar 27, 2024
View reviewed changes
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I simulated it locally and looks good to me but I would change the wording a little bit.

src/components/TheHeader.vue Outdated Show resolved Hide resolved
michele-franchi
michele-franchi approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@michele-franchi michele-franchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor typo but looks good

src/components/TheHeader.vue Outdated Show resolved Hide resolved
@janmichek @michele-franchi
fix typo
f6ff2af 
Co-authored-by: Michele F. <michele-franchi@users.noreply.github.com>
@janmichek janmichek merged commit 1c9b7e5 into develop Mar 28, 2024
2 checks passed
@janmichek janmichek deleted the Warning-about-MDW-out-of-sync branch March 28, 2024 10:00
@aeternity-bot aeternity-bot mentioned this pull request Apr 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liubov-crypto Liubov-crypto Liubov-crypto requested changes

@michele-franchi michele-franchi michele-franchi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warning about MDW out of sync
3 participants
@janmichek @Liubov-crypto @michele-franchi