Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Мempool #221

Closed
2 of 7 tasks
joelreymont opened this issue Sep 28, 2017 · 5 comments
Closed
2 of 7 tasks

Мempool #221

joelreymont opened this issue Sep 28, 2017 · 5 comments
Assignees
Labels

Comments

@joelreymont
Copy link
Contributor

joelreymont commented Sep 28, 2017

Tracking ticket for all the things mempool.

@joelreymont joelreymont self-assigned this Sep 28, 2017
@joelreymont joelreymont changed the title Modify mempool The mempool Sep 28, 2017
@joelreymont joelreymont changed the title The mempool Мempool Sep 28, 2017
@sennui
Copy link
Contributor

sennui commented Oct 3, 2017

moving the note here:

Add ticket to improve mempool (batch API for delete) Consult with Luca. I commented and accepted the first PR #240)

@sennui
Copy link
Contributor

sennui commented Oct 3, 2017

where do we want to catch duplicated transaction. Current solution will not catch two same txs with different fees

@sennui
Copy link
Contributor

sennui commented Oct 3, 2017

cc: @lucafavatella ^^

@lucafavatella
Copy link
Contributor

@zp-sd I added in backlog of “Core” project a note “Optimize mempool”.

Currently in master the mempool process is only responsible for (1) initializing the txs in-memory storage and (2) proxying peek/put/delete operations. Wrt potential future changes to mempool for limiting transfer of data between heaps of mempool process and its client (that we briefly mentioned yesterday), responsibility (2) may be removed from mempool process by choosing an in-memory sorted ETS table (and catch a few error cases when attempting to peek multiple txs) - hence removing the mempool process from peek/put/delete operations. Though I suggest deferring optimizations like this to after the usage of the mempool is more firmly established e.g. nature of key, potential secondary indexes, and guarantee of additional constraints needing the serializing process.

@joelreymont
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants