Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login with iframe wallet #240

Open
Liubov-crypto opened this issue Sep 7, 2020 · 9 comments
Open

Login with iframe wallet #240

Liubov-crypto opened this issue Sep 7, 2020 · 9 comments

Comments

@Liubov-crypto
Copy link

I cannot enter the room using the iframe wallet. I only see endless loading:

Знімок екрана 2020-09-07 о 11 16 54 дп

Знімок екрана 2020-09-07 о 12 39 35 пп

I recorded a video: https://youtu.be/c98fQmD-ka8

I checked several times, cleared the cache and history, overloaded the laptop, but it still does not work.

browsers: firefox, chrome

@Liubov-crypto
Copy link
Author

Liubov-crypto commented Sep 7, 2020

The same issue with pop-ups was found in Safari as well (we tested with Sergii):
iframe bug

I think it would be better to write something like this on this pop-up: "Please allow pop-ups and try to join meeting again."

@venimus
Copy link
Member

venimus commented Sep 8, 2020

Looks like connectivity issues

@Liubov-crypto
Copy link
Author

I tested login with iframe in different browsers. I removed the extension from everywhere and cleared the cache and cookies. Found one interesting feature in the login algorithm:

browsers: chrome, firefox, brave

Login with iframe wallet works:

Go to superhero.com/meet
Click on Go button
Login with iframe wallet
Click on Accept Pop up

(In chrome/firefox pop-ups appears 2 times, in Brave only 1 time)

Login with iframe wallet doesn’t work:

Go to superhero.com/meet
Login with iframe wallet or you are already logged in
Click on Go button
Wait when the pop-up appears
Error: no pop-up

If the user has already login with the iframe wallet and then tries to enter the Jitsi room, the pop-ups may not appear. And it makes it difficult to enter the room. but if you change the login algorithm, then everything works.

@mike-gusev-ae
Copy link

Go to superhero.com/meet
Login with iframe wallet or you are already logged in
Click on Go button
Wait when the pop-up appears
Error: no pop-up

for me, it appears only when i click go button so fast.
when i was waiting while my wallet connected, it always works well.
we discussed it with @Liubov-crypto , but she still has this bug, idk why.

@Liubov-crypto
Copy link
Author

When I tried to login with iframe wallet in private mode and in Brave browser, a wallet is not available.

Знімок екрана 2020-09-29 о 5 01 48 пп

Знімок екрана 2020-09-29 о 5 17 05 пп

@sergs1207
Copy link

Brave browser has function to enable crypto wallets
But even after enabling issue is still present
Screenshot 2020-10-01 at 10 19 40
Screenshot 2020-10-01 at 10 19 21

@davidyuk
Copy link
Member

davidyuk commented Oct 2, 2020

the last bug is fixed by this hotfix

@davidyuk
Copy link
Member

davidyuk commented Oct 2, 2020

When I tried to login with iframe wallet in private mode and in Brave browser, a wallet is not available.

In Chrome you need to uncheck the switch on a new tab to enable wallet to use LocalStorage:

Screenshot 2020-10-02 at 13 33 02

@davidyuk
Copy link
Member

davidyuk commented Oct 6, 2020

is this issue resolved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants