[SW-1183] feat: adjust invite links #2274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CedrikNikita
force-pushed
the
feature/improve-invite-links
branch
from
8675ccb
to
8dfdf23
Compare
CedrikNikita
changed the title
|
LGTM, tested migration as well. |
davidyuk
reviewed
Aug 28, 2023
There was a problem hiding this comment.
If you wait a bit you could use the format we agreed in aeternity/aeserialization#19
| newState.invites.invites = newState.invites.invites | ||
| .map((invite) => ({ | ||
| ...invite, | ||
| secretKey: Buffer.from(invite.secretKey, 'hex').slice(0, 32), |
There was a problem hiding this comment.
Maybe store serialized the same was as in invite links 🤷♀️
CedrikNikita
force-pushed
the
feature/improve-invite-links
branch
from
8dfdf23
to
7e4aa20
Compare
peronczyk
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2057