Support List options #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we hit the limit of our current implementation. We currently don't handle nested structures, whereas go-querystring provides the "same" feature but it also does. It was a nice game to create such custom `url:` handler, but it is worthless to make further changes as I end up reimplementing pretty much the same amount of code.
weppos
added
the
ready-for-review
|
Ready for review. |
| // Here's a few example: | ||
|
|
||
| // get the list of domains filtered by name and sorted by expiration | ||
| client.Domains.ListDomains(whoami.Account.ID, &DomainListOptions{NameLike: "com", Sort: "expiration:DESC"}) |
This was referenced Jun 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new sort and filter options.