Make this package implementation-agnostic

[nex3]

Rather than always loading Node Sass, this now requires users to pass
in either Dart Sass or Node Sass as an option to the plugin.

Closes #184

[nex3]

This pull request isn't complete, but I got as far as I could given my limited knowledge of Ember. I'm not sure how to pass a Sass implementation in to the tests--it doesn't look like there's any actual invocation of new EmberApp() like there is in the README.

[nex3]

It seems like we should be encouraging users to pass in a Sass implementation here, but I'm not sure how.

[jbailey4]

@nex3 @aexmachina Is this branch nex3:dart-sass in a workable state allowing consumers to pass dart-sass, it's just tests that are failing?

My team wants to get away from node-sass asap and this is currently the blocker.

If there is anything I can help with let me know...

[jbailey4]

I'm not sure how to pass a Sass implementation in to the tests

@nex3 The tests builds the dummy app (/tests/dummy), could you add the sass implementation option here as well.

[nex3]

@nex3 @aexmachina Is this branch nex3:dart-sass in a workable state allowing consumers to pass dart-sass, it's just tests that are failing?

As far as I know, but I want to emphasize that I'm not an expert in Ember or this package so I can't make any guarantees that I did anything right.

@nex3 The tests builds the dummy app (/tests/dummy), could you add the sass implementation option here as well.

Thanks, done!

[jbailey4]

@aexmachina Looks like the latest change @nex3 made, adding the sass implementation to ember-cli-build.js, got the tests passing! If that's enough to land this, it would be awesome to get this in.

[simonexmachina]

I think it'd be good for this addon to install sass into the user's package.json. @jbailey4 do you know how to get an addon to do this?

[simonexmachina]

Published v9.0.0 👍

[jbailey4]

I think it'd be good for this addon to install sass into the user's package.json

@aexmachina We could do this via addPackageToProject in a default blueprint. However, the updated README includes instructions on installing sass or node-sass with this addon. Since other SASS implementations exist and are still supported (e.g. node-sass), it may be better having this addon not assume the implementation.

[simonexmachina]

However, a lot of people just ember install and expect it to work. I think adding sass to the project is the path of least resistance and offers the least chance of problems. I'm not using this module any more, do you feel like doing a quick PR?

[jbailey4]

I'm not using this module any more, do you feel like doing a quick PR?

@aexmachina Checkout #192