Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update core.ts #222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update core.ts #222

wants to merge 1 commit into from

Conversation

huseeiin
Copy link

fix #221

af
af requested changes Apr 24, 2024
View reviewed changes
src/core.ts
const usingDevDefault =
rawNodeEnv && rawNodeEnv !== 'production' && spec.hasOwnProperty('devDefault')
rawNodeEnv !== 'production' && spec.hasOwnProperty('devDefault')
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change causes a regression unfortunately– when NODE_ENV isn't provided, envalid assumes "production" mode. It's the safest choice in case for some reason your prod env doesn't have NODE_ENV set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@af af af requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

devDefault does not work when NODE_ENV is undefined
2 participants
@huseeiin @af