Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default not working anymore #23

Closed
rastkojokic opened this issue Jan 2, 2017 · 5 comments
Closed

Default not working anymore #23

rastkojokic opened this issue Jan 2, 2017 · 5 comments

Comments

@rastkojokic
Copy link

Hey guys! It seems that from the [https://github.com/af/envalid/commit/68f95bd4012b3f3017a67e0f50a2dece1de0ce00](last commit) default is not working anymore... This part of the code haven't exported the variable:

SOME_VAR: envalid.str({ default: '127.0.0.1' })
@af
Copy link
Owner

af commented Jan 2, 2017

Thanks for the report, I'm looking into it!

@af
Copy link
Owner

af commented Jan 2, 2017

Hi @rastkojokic, the test suite covers this case, and it's still passing, so I'm not sure what's going on here. Could you post a larger code snippet? Also are you using v2.4.2 direct from npm?

@SimenB
Copy link
Collaborator

SimenB commented Jan 3, 2017

Default works for me

@af
Copy link
Owner

af commented Jan 3, 2017

I double-checked on one of my projects last night and it's working for me too. @rastkojokic what is the output for SOME_VAR in your case? Undefined, or does it throw an error?

@af
Copy link
Owner

af commented Jan 7, 2017

Closing until we can get a repro case or more information

@af af closed this as completed Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@af @SimenB @rastkojokic