Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript type declarations #24

Closed
ibratoev opened this issue Feb 14, 2017 · 3 comments
Closed

Typescript type declarations #24

ibratoev opened this issue Feb 14, 2017 · 3 comments

Comments

@ibratoev
Copy link
Contributor

Adding Typescript type declarations will make the package easier to integrate in Typescript projects.

I am currently using it with Typescript and I can contribute the typings. @af, are you interested in a PR?
@af
Copy link
Owner

af commented Feb 14, 2017

Hi,

The API is pretty stable at this point so I think it'd be reasonable to add them. I don't use Typescript myself (yet) so I can't commit to updating them when/if APIs change. I'd welcome a PR for sure, thanks!

@af
Copy link
Owner

af commented Feb 14, 2017

Closing this issue for now, will revisit when there's a PR

@af af closed this as completed Feb 14, 2017
@ibratoev
Copy link
Contributor Author

Thanks, @af. Can you check my other issue and I can send you a PR after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@af @ibratoev