Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Missing HTML example? #90

Closed
mhulse opened this issue Feb 20, 2013 · 6 comments
Closed

README: Missing HTML example? #90

mhulse opened this issue Feb 20, 2013 · 6 comments

Comments

@mhulse
Copy link

mhulse commented Feb 20, 2013

Stoopid question, but is it still recommended to use IE conditional:

<!--[if lt IE 9]>
<script src="dist/html5shiv.js"></script>
<![endif]-->

I've even been using:

<!--[if (lt IE 9) & (!IEMobile)]>
<script src="dist/html5shiv.js"></script>
<![endif]-->

I didn't see an example of this in the README, so does that mean I don't need to use the conditional comments anymore?

If I do, or if it is best practice to use IE conditional comments, which syntax is best?

Thanks!
Micky

@jonathantneal
Copy link
Collaborator

html5shiv handles html5 issues in non-ie browsers, specifically in styling. Take a look.

https://github.com/aFarkas/html5shiv/blob/master/src/html5shiv.js#L215-218

@mhulse
Copy link
Author

mhulse commented Feb 20, 2013

@jonathantneal Thanks for the reply/help, I really appreciate it. :)

I only asked because I've been using the html5shiv since the Google repo days:

http://code.google.com/p/html5shiv/

... as you can see, that page the example has IE conditional.

I remember reading that using the IE conditional is just a way to save on network request for browsers that already understand HTML5. I'm sure that's still the case, I just wanted to confirm my assumptions.

Thanks again for the help!

@jonathantneal
Copy link
Collaborator

You're very welcome. Thanks for asking. I'll ask @remy to update the example.

@mhulse
Copy link
Author

mhulse commented Feb 20, 2013

Thanks @jonathantneal! Have a great day. 👍

@mhulse
Copy link
Author

mhulse commented Feb 20, 2013

Just a quick update, I was reading around the net, and it sounds like a certain version of Windows Phone 7 will support HTML5?

For example:

The next Windows Phone 7 update, code named Mango, will have IE Mobile 9, which contains HTML5 support. It'll be the first major update for WP7, but might not have Silverlight browser support after all. It's unclear if third-party multitasking and Twitter integration will make it.

I also found people using:

<!--[if (lt IE 9) & (!IEMobile 7)]>
<![endif]-->

... but now I'm wondering if it should be:

<!--[if (lt IE 9) & (lt IEMobile 9)]>
...
<![endif]-->

Note: I'm not sure about the & in there.

I need to do more research ... I don't have windows mobile devices, so some of this is just speculation. 👯

@mhulse
Copy link
Author

mhulse commented Feb 20, 2013

Ahh, there appears to be no IE Mobile version 8! So this logic should suffice:

<!--[if (lt IE 9) & (!IEMobile 7)]>
...
<![endif]-->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants