Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add git tags for versions #39

Open
mark-feeney-sage opened this issue Mar 1, 2019 · 3 comments
Open

Add git tags for versions #39

mark-feeney-sage opened this issue Mar 1, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@mark-feeney-sage
Copy link

It would be great to be able to reference a version by git tag, for development and dependency management. Is there a reason not to do so?
Versions with no corresponding tags are already cited in sfdx-project.json.

@ImJohnMDaniel
Copy link
Collaborator

Hey @mark-feeney-sage -- So, basically, you are asking for us to reference stable points in time of the project by GIT tags since this is a non-packaged project and thus can't make use of version numbers. Am I understanding your ask correctly?

@mark-feeney-sage
Copy link
Author

Hi @ImJohnMDaniel. If that is the case (non-packaged, no version numbers), yes, it would be handy. I thought there were version numbers, as referenced in those sfdx project package aliases. If there's some other means by which others use this library in production, or I'm missing some Salesforce pattern that's normally used, it'd be great to know.

@ImJohnMDaniel
Copy link
Collaborator

Hey @mark-feeney-sage -- Thanks for the clarification.

Yeah, @afawcett, @douglascayers, and I have been going back and forth about whether or not maintain a packaged version of this project or simply maintain the codebase and let the developers who use the code to decide how they want to package it. Personally, I have this packaged as part of a larger, 'foundation package' at work and I have a client that has it as an independent/standalone package. The choice is totally up to you.

As for a 'stable release marker', it is not a bad idea. Something we can discuss going forward.

Andy and Doug -- any thoughts?

@afawcett afawcett added the enhancement New feature or request label Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants