Skip to content
This repository has been archived by the owner on Jun 24, 2022. It is now read-only.

Bundle as plugin when Kirby 2.3 is released #10

Closed
jenstornell opened this issue May 11, 2016 · 14 comments
Closed

Bundle as plugin when Kirby 2.3 is released #10

jenstornell opened this issue May 11, 2016 · 14 comments

Comments

@jenstornell
Copy link

No description provided.

@jenstornell
Copy link
Author

2.3 has been released. :)

@afbora
Copy link
Owner

afbora commented May 19, 2016

What can i do for this? 😄

@dweidner
Copy link

dweidner commented Jun 8, 2016

One think could be to add a package.json file to allow installing your field via the new Kirby CLI. See the following page for more details: https://github.com/getkirby/cli#kirby-plugininstall

@jenstornell
Copy link
Author

@dweidner
Copy link

dweidner commented Jun 8, 2016

Well the extension registry would only make sense, if this "plugin" provides more functionality than a panel field, for example providing additional field methods. Users are supposed to install the files into site/fields and not into site/plugins. There is no need to use the extension registry here.

@jenstornell
Copy link
Author

I quote one of the crew members:

https://forum.getkirby.com/t/multiselect-field/1213/19

With the new registry in Kirby 2.3, I believe all third-party elements like fields, snippets, blueprints etc. should also be delivered wrapped as a plugin. This enables us to keep only custom elements that are rather specific to the project in site/fields, site/tags etc.

@afbora
Copy link
Owner

afbora commented Jun 8, 2016

@dweidner @jenstornell Added 72ce2ee

@dweidner
Copy link

dweidner commented Jun 8, 2016

Thank you for the reference, @jenstornell. I have to disagree though. I would expect fields to be in the site/fields folder regardless of the author of a field/plugin.

@afbora
Copy link
Owner

afbora commented Jun 8, 2016

Specified as type: kirby-field in package.json

@jenstornell
Copy link
Author

It seems like you have @dweidner on your side as he setup the package.json as field. I have not changed my mind about it tho.

@dweidner
Copy link

dweidner commented Jun 8, 2016

I think we should move the discussion to another issue: https://github.com/distantnative/field-multiselect/issues/18

@malvese
Copy link

malvese commented Sep 2, 2016

When I try to install the plugin with Kirby's CLI I get this error:
[RuntimeException] Invalid Kirby Plugin Type

@afbora
Copy link
Owner

afbora commented Dec 7, 2016

@malvese Could you try with downloaded new version?

@malvese
Copy link

malvese commented Dec 13, 2016

@afbora Sorry for the delay! I just tried and it now works fine :) Thanks!

@afbora afbora closed this as completed Dec 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants