Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI pipeline only tests Python version 3.8 #338

Closed
havardAasen opened this issue Sep 27, 2023 · 5 comments · Fixed by #340
Closed

CI pipeline only tests Python version 3.8 #338

havardAasen opened this issue Sep 27, 2023 · 5 comments · Fixed by #340
Labels

Comments

@havardAasen
Copy link

Even though the header reads Python versions ranging from 3.8 to 3.12, it is only testing towards Python 3.8. This is seen during test, build and install stage. I suspect that the pipeline for Python 3.12 will fail if it would be tested.

There is also some deprecation warnings regarding actions/checkout@v2 and actions/setup-python@v1.

@GuillaumeSeren
Copy link
Collaborator

Hey @havardAasen ,
last master push was again 3.8 to 3.12 https://github.com/afewmail/afew/actions/runs/5391100743

Can you provide more precision on this issue ?

Thank you

@havardAasen
Copy link
Author

I'll add a photo, perhaps it describe the problem better.

In short, the Ci pipeline is configured incorrectly. You believe it tests 3.8 to 3.12 but it only tests against 3.8

This is the last job for the master branch, claimed to build and test against 3.12, but in reality it is 3.8
https://github.com/afewmail/afew/actions/runs/6945577376/job/18895266536#step:6:16

python3 8

@havardAasen
Copy link
Author

@GuillaumeSeren
I see you haven't removed the waiting-reply label, are you unsatisfied with the one i provided?

@GuillaumeSeren
Copy link
Collaborator

Hey @havardAasen ,
yes sorry I didn't understand the issue on the first post.

So it seems the test are always run on python-3.8 for some reason,
it is not supposed to be like that, we have to investigate.

@GuillaumeSeren
Copy link
Collaborator

Oh I think I get it,
after searching and debugging the ci file, there was a big issue,
thank you taking the time to report this 👏

The issue was, in the following code of the runner:

      - name: Set up Python
        uses: actions/setup-python@v1
        with:
          python-version: '${{ matrix.python }}'

# But the name of the list of available python version defined earlier
# in the file is python-version

    strategy:
      matrix:
        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]

After fixing the variable we can now see the right python version,
and discover a issue on python-3.12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants