Added support for CloseNotify in the event stream #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there a test you can write verifying the old behavior is fixed? |
|
Originally I had confirmed the code manually via curl. Getting Go1.4 to behave properly with request cancellations is a bit ugly, but after a few gyrations I got it working. Apparently 1.5 adds a http.Request.Cancel channel to make canceling long-running responses easier (learned this today in my research), but I didn't want to presume people had upgraded to 1.5 yet. |
| buf := []byte{0} | ||
| res, err := client.Do(req) | ||
| if err != nil { | ||
| log.Fatal(err) |
There was a problem hiding this comment.
are these logging statements necessary?
There was a problem hiding this comment.
Nope, I'll remove them.
|
thanks for this fix! |
afex
added a commit
that referenced
this pull request
Sep 9, 2015
Added support for CloseNotify in the event stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StreamHandlers were hanging around after clients disconnected and creating noise. I suppose with enough hits to ServeHTTP it could have eventually impacted legitimate clients via port exhaustion, etc.