Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PubSub subscribe message redundant packed flag #1

Closed
davxy opened this issue Oct 4, 2021 · 1 comment · Fixed by #2
Closed

PubSub subscribe message redundant packed flag #1

davxy opened this issue Oct 4, 2021 · 1 comment · Fixed by #2
Assignees
@davxy
Labels
enhancement New feature or request

Comments

@davxy
Copy link
Contributor

davxy commented Oct 4, 2021

Subscribe blockchain message contains an explicit boolean to explicitly request for packed messages on the subscription messages:

trinci-core/src/blockchain/message.rs

Line 44 in 925fbba

Subscribe {

This can be made implicit by following the following rule:

  • if the subscribe message was received as packed then send out packed messages
  • else send out unpacked messages
@davxy davxy added the enhancement New feature or request label Oct 4, 2021
@davxy davxy self-assigned this Oct 4, 2021
@davxy
Copy link
Contributor Author

davxy commented Oct 6, 2021

@avitsiuk perhaps this change also involves t2lib?

@davxy davxy mentioned this issue Oct 6, 2021
Merged
@davxy davxy closed this as completed in #2 Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davxy davxy

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implicit packed message request for Message::Subscribe davxy/trinci-core
1 participant
@davxy