Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renko backtest #2

Closed
DaveAndersonCo opened this issue Feb 23, 2021 · 3 comments
Closed

Renko backtest #2

DaveAndersonCo opened this issue Feb 23, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@DaveAndersonCo
Copy link

Hi,

I think this library is broken. Following this post https://ctrader.com/forum/third-party-products/22572 , I am trying to run the example in the post but it fails on OnTick() with an not implemented exception from inside the library, inside 'IndicatorMarketSeries' :

public DataSeries OpenPrices => throw new NotImplementedException();

I looked into it a bit and see that in the past updates the 'Bars' has been partially implemented and therefore it doesn't work.
Unfortunately the earlier commits have other bugs and make them useless.

Would you like to see if this can be fixed? It would be a shame for the effort that went into this great idea :-)

Regards,
Dave

@amusleh-spotware-com
Copy link
Owner

I'm aware of the issues, I will fix the issues whenever I got some free time.

@amusleh-spotware-com
Copy link
Owner

The issues has been resolved.

@amusleh-spotware-com amusleh-spotware-com added the bug Something isn't working label Mar 1, 2021
@DaveAndersonCo
Copy link
Author

DaveAndersonCo commented Mar 5, 2021

Hi afhacker,

Great job on this. I really appreciate it.

But unfortunately I think it is not completely fixed. Your example on this post https://ctrader.com/forum/third-party-products/22572?page=1#post-1 still doesn't work.

I think it has to do with this issue: https://ctrader.com/forum/calgo-support/23880#post-2

Therefore your great RenkoBars cannot be used with any indicator.

This would be the exception on initializing any indicator:
Unable to cast object of type 'cAlgo.API.Extensions.Series.RenkoBars' to type 'cTrader.Automate.Small.V1.MarketApi.ISmallChartSource'.

Unless you come up with something ingenious again ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants