-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] Upload Error #71
Comments
Logs:
|
Just to add onto this - just tested it out locally. Upload works fine when testing locally, which might explain why the unit tests aren't catching any errors. Believe they're performed within the github actions (container?) environment. |
Turns out no error in the code! Upload test was done using a "fcsv" file that contained html instead of fiducials. Results in 500 error. @tkkuehn @Park-Patrick |
Error was encountered again at Brainweb. Somethign we discussed yesterday that maybe what we should be doing is chceking the first few lines of the file, and if it does not match what is expected, throw a meaningful error. Additionally, validator (should not currently) be saving any of the contents of these files if error is encountered as it doesn't get to that stage. |
See #79, which addresses the issue of invalid content |
PR for checking the invalid content has been merged. There are two checks implemented here:
Thanks @tkkuehn |
Upload of fcsv throws error with message below:
Unit test isn't catching error
@tkkuehn - please add log
The text was updated successfully, but these errors were encountered: