Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming of files #34

Closed
knallvar opened this issue Oct 9, 2021 · 1 comment
Closed

Renaming of files #34

knallvar opened this issue Oct 9, 2021 · 1 comment

Comments

@knallvar
Copy link

knallvar commented Oct 9, 2021

I just compiled sfm and like it very much already. Thanks for providing this! I ran into one stumble block though...

I doesn't seem to be possible to use spaces or non-english characters when renaming files with the cw command. Is this a bug? Would it be possible to add this functionality?

Also, if the filename is very long (like 60 characters), you only get the remaining character space left on the line to use for renaming the file (like 10 characters). Perhaps to skip showing the original name on the editing line could be a good idea (since you see which file you have selected for editing in the file list above anyway). Or rather, one could have the original name there for editing (like if you have a long filename and just want to change one or two characters).

So what do you say?

@afify
Copy link
Owner

afify commented Oct 9, 2021

I just compiled sfm and like it very much already. Thanks for providing this! I ran into one stumble block though...

Hello @knallvar, i'm happy you find sfm useful

I doesn't seem to be possible to use spaces or non-English characters when renaming files with the cw command. Is this a bug? Would it be possible to add this functionality?

Yes "for now" spaces and non-English are not supported, it will be helpful if you make a pull request to add these features

Also, if the filename is very long (like 60 characters), you only get the remaining character space left on the line to use for renaming the file (like 10 characters). Perhaps to skip showing the original name on the editing line could be a good idea (since you see which file you have selected for editing in the file list above anyway). Or rather, one could have the original name there for editing (like if you have a long filename and just want to change one or two characters).

Good idea, this could be your 2nd pull request, good luck !

@afify afify closed this as completed Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants