Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribuciones #32

Closed
juanpsenn opened this issue Apr 20, 2022 · 3 comments
Closed

Contribuciones #32

juanpsenn opened this issue Apr 20, 2022 · 3 comments

Comments

@juanpsenn
Copy link

Hola! Me gustaria poder contribuir a la libreria, agregar algun que otro test por ejemplo.
Hay guias de contribucion? Estan aceptando contribuciones?

Saludos!

@ivanalemunioz
Copy link
Collaborator

si se aceptan, no hay guia jeje

@juanpsenn
Copy link
Author

juanpsenn commented May 27, 2022

Buenas, perdon por desaparecer jaja. Estaba pensando como encarar el tema de garantizar un minimo de testing.
No tengo mucha experiencia en js pero creo que algo asi juanpsenn@be5e910 podria resultar.

Utilice credenciales de testing propias y jest para manejar los tests, si les parece sigo adelante con la implementacion.

@braianj
Copy link

braianj commented Aug 10, 2022

Esta bastante bien ese test para arrancar. no se si subiria las key y tu propia cuit, pensaria en algo ams generico

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants