Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add release tarball with sources including submodules #159

Closed
jirutka opened this issue Jul 20, 2021 · 2 comments
Closed

Add release tarball with sources including submodules #159

jirutka opened this issue Jul 20, 2021 · 2 comments
Labels
enhancement New feature or request
Projects

Comments

@jirutka
Copy link
Contributor

jirutka commented Jul 20, 2021

The source code tarballs that GitHub automatically generates (e.g. https://github.com/afnanenayet/diffsitter/archive/refs/tags/v0.6.6.tar.gz) don’t include git submodules.

Can you please pack tarball with all sources, including submodules, as part of the release process? This will make it easier for Linux distributions to package diffsitter.

@jirutka jirutka added the enhancement New feature or request label Jul 20, 2021
@afnanenayet afnanenayet added this to To do in Features Sep 27, 2021
@afnanenayet
Copy link
Owner

Is this still as necessary now that diffsitter supports dynamically linking against grammars? Some other people have expressed that they'd rather package the tree-sitter libraries separately and have the diffsitter package depend on them. If you still want a tarball with all submodules, happy to work on it.

@jirutka
Copy link
Contributor Author

jirutka commented Oct 18, 2021

Yes, I’ll still appreciate tarball with the submodules.

Features automation moved this from To do to Done Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Development

No branches or pull requests

2 participants