Add support for 'About Libraries' Android library #1411
Conversation
| <string name="library_materialdialogs_isOpenSource">true</string> | ||
| <string name="library_materialdialogs_repositoryLink">https://github.com/afollestad/material-dialogs</string> | ||
| <string name="library_materialdialogs_classPath">com.afollestad.materialdialogs.MaterialDialog</string> | ||
| <string name="library_materialdialogs_licenseId">mit</string> |
There was a problem hiding this comment.
@piotrek1543 Are you referring to the materialdialogs portion of the string name? It doesn't actually matter for developers as the strings are converted to all lower case when they request it. If you'd like I can make them upper case.
There was a problem hiding this comment.
@AllanWang i was curious about why 'mit' is lowercase. No, I don't see this change as necessary
There was a problem hiding this comment.
@piotrek1543 these strings were done by another user and I just copied them over. mit is a keyword used by the library to generate the license. You can see in the screenshot (which is updated) that it becomes "MIT License".
If there are any issues in the description of the app that can be updated. (Again, written by another user based on how MD was at the time)
|
Update please screenshot - add one with right API value |
|
Change also this misleading MR name - it's more for supporting another library than just creating a new about file. Maybe: 'Adding support for 'About Libraries' Android library' Then you would have my approval |
AllanWang
changed the title
|
@AllanWang lol, it seems that only author of this repo can review this correctly and then merge. For me it's nice-to-have feature, so... approve. |
|
@piotrek1543 That's fine. Thanks for the approval |
This is to support About Libraries, a library to facilitate listing dependencies. Your project is currently embedded in that project, which means the version number needs to be manually changed. Having it in your project directly along with the
resValuein gradle will make this automatic.These resources will be removed if users have proguard. Those who choose to use about libraries with proguard will keep the R classes to resolve that.
Attached below is an example of how it looks. (Note that the UI can be customized, but the text will be the same throughout projects)