Skip to content
This repository has been archived by the owner on Sep 3, 2023. It is now read-only.

Fix vibrating windows #169

Merged
merged 1 commit into from Jan 6, 2015
Merged

Fix vibrating windows #169

merged 1 commit into from Jan 6, 2015

Conversation

teslacoil
Copy link

Some windows with just the right amount of scrollable content would trigger the
removal of the bottom margin, however the new layout pass would show that the
content is no longer scrollable so the bottom margin would be reenabled.
This would cause the window to continously vibrate up and down.

This fix verifies the available space before adding the margin, and doesn't
add it, if it would cause the content to scroll.

Some windows with just the right amount of scrollable content would trigger the
removal of the bottom margin, however the new layout pass would show that the
content is no longer scrollable so the bottom margin would be reenabled.
This would cause the window to continously vibrate up and down.

This fix verifies the available space before adding the margin, and doesn't
add it, if it would cause the content to scroll.
@afollestad
Copy link
Owner

Awesome, thanks

afollestad added a commit that referenced this pull request Jan 6, 2015
@afollestad afollestad merged commit 4e9927d into afollestad:master Jan 6, 2015
@afollestad
Copy link
Owner

Release 0.5.9 is now available

@ZacSweers
Copy link
Contributor

This doesn't seem to have fixed it for me, I still see the vibration on lists that are slightly larger than the available space.

@ZacSweers
Copy link
Contributor

Also items don't seem to be focusable when the hitter is occurring. The click is registered, but the item view doesn't update, nor is there any ripple 😦

@afollestad
Copy link
Owner

@afollestad
Copy link
Owner

@hzsweers I figured out why there's no selector. Before it was explicitly set to the list item layout backgrounds. I removed that because I thought they were set via code. Now that I was going through and adding customizable selectors, I found and fixed the issue.

@ZacSweers
Copy link
Contributor

Well it wasn't just the selector. It wouldn't update the item to be marked
as "clicked" either :/

Any luck with the jiggly windows?

On Fri, Jan 9, 2015, 11:08 AM Aidan Follestad notifications@github.com
wrote:

@hzsweers https://github.com/hzsweers I figured out why there's no
selector. Before it was explicitly set to the list item layout backgrounds.
I removed that because I thought they were set via code. Now that I was
going through and adding customizable selectors, I found and fixed the
issue.


Reply to this email directly or view it on GitHub
#169 (comment)
.

@afollestad
Copy link
Owner

@hzsweers try out the latest code, it's working for me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
4 participants