Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing icon for Promotion Status Plugin #38

Closed
nfalco79 opened this issue Feb 11, 2016 · 8 comments
Closed

Missing icon for Promotion Status Plugin #38

nfalco79 opened this issue Feb 11, 2016 · 8 comments

Comments

@nfalco79
Copy link
Contributor

Some SVG is missing for this plugin and some glitches about it with this new thema:
promotionstatus

Also the promotion page has strange background:
promotionstatus_page

and also badges in the build history has abnormal red ball as background:
promotionstatus_badge

  • Jenkins 1.625.3
  • Firefox
@afonsof
Copy link
Owner

afonsof commented Feb 11, 2016

Thanks a lot for filing this issue! Would you like to write a patch for this? We'd be more than happy to walk you through the steps involved.

@afonsof afonsof added the bug label Mar 5, 2016
@afonsof
Copy link
Owner

afonsof commented Mar 6, 2016

@nfalco79 what's the plugin?
image

@nfalco79
Copy link
Contributor Author

nfalco79 commented Mar 9, 2016

this one "promoted builds plugin" is the oldest plugin

@AlexanderPoleschuk
Copy link

There are actually more icons that are not shown in your theme. They exist on the page, but they are not displayed because of your strict override rules.
The good examples that I've faced with are: Selenium Grid plugin and Allure Report plugin.
See attachments.
3-11-2016 12-54-08 pm
3-11-2016 1-02-24 pm

@afonsof
Copy link
Owner

afonsof commented Mar 22, 2016

Yes I know @AlexanderPoleschuk. I'm sorry, I'm trying to fix this. The global override was the only way I found to handle all the icons in the same way and not increase drastically the css size. Before that we were getting wrong sized icons in a sort of places or more than one selector to treat the same kind of icon due to jenkins plugins inconsistencies.

@afonsof
Copy link
Owner

afonsof commented Mar 25, 2016

@AlexanderPoleschuk and @nfalco79 I've just updated the theme to the version 1.2.2. No icon will be blank anymore. Unfortunately this change has increased the file size a little bit. I'll fix the problem with Material Design icons later.

@nfalco79
Copy link
Contributor Author

Good work!

@nfalco79
Copy link
Contributor Author

Resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants