-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing icon for Promotion Status Plugin #38
Comments
Thanks a lot for filing this issue! Would you like to write a patch for this? We'd be more than happy to walk you through the steps involved. |
@nfalco79 what's the plugin? |
this one "promoted builds plugin" is the oldest plugin |
Yes I know @AlexanderPoleschuk. I'm sorry, I'm trying to fix this. The global override was the only way I found to handle all the icons in the same way and not increase drastically the css size. Before that we were getting wrong sized icons in a sort of places or more than one selector to treat the same kind of icon due to jenkins plugins inconsistencies. |
@AlexanderPoleschuk and @nfalco79 I've just updated the theme to the version 1.2.2. No icon will be blank anymore. Unfortunately this change has increased the file size a little bit. I'll fix the problem with Material Design icons later. |
Good work! |
Resolved |
Some SVG is missing for this plugin and some glitches about it with this new thema:
![promotionstatus](https://cloud.githubusercontent.com/assets/4160180/12979430/58f806b4-d0d7-11e5-9a79-67806eac1ece.jpg)
Also the promotion page has strange background:
![promotionstatus_page](https://cloud.githubusercontent.com/assets/4160180/12979460/ad831854-d0d7-11e5-9706-837241d97bf5.jpg)
and also badges in the build history has abnormal red ball as background:
![promotionstatus_badge](https://cloud.githubusercontent.com/assets/4160180/12979475/c1380986-d0d7-11e5-9452-35d797db1efe.jpg)
The text was updated successfully, but these errors were encountered: