Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: landscape layout support #34

Merged
merged 28 commits into from
Apr 24, 2024
Merged

feat: landscape layout support #34

merged 28 commits into from
Apr 24, 2024

Conversation

afonsosousah
Copy link
Owner

@afonsosousah afonsosousah commented Mar 16, 2024 •
edited
Loading

Adiciona um layout para o ecrã horizontal, permitindo que a app seja utilizada em modo landscape no suporte de telemóvel da bicicleta, sem que esteja em navegação.
De momento a 3D view não será implementada neste modo, pois não é possível carregar nos pontos das estações no mapa.
Remove a necessidade do aviso de rodar o ecrã.

To-do

  • Add support for the navigation in any orientation
  • Set the default on the navigation UI to follow user, and when user touches on the map, it stops following the user and a button to snap back to the user is shown
  • rename "updatePositionAndRotationWhenInNavigationUI"

@afonsosousah afonsosousah changed the title feat: starting horizontal support feat: horizontal support Mar 16, 2024
@afonsosousah afonsosousah changed the title feat: horizontal support feat: landscape layout support Mar 16, 2024
@afonsosousah afonsosousah self-assigned this Mar 16, 2024
@afonsosousah afonsosousah added the enhancement New feature or request label Mar 16, 2024
@afonsosousah afonsosousah added this to the v0.0.5 milestone Mar 16, 2024
@afonsosousah afonsosousah linked an issue Mar 16, 2024 that may be closed by this pull request
feat: navigation UI when on trip and horizontal mode #26
Closed
@afonsosousah
Copy link
Owner Author

rebase

@afonsosousah
Copy link
Owner Author

rebased

@afonsosousah
Copy link
Owner Author

rebased

afonsosousah and others added 22 commits April 24, 2024 00:37
@afonsosousah
feat: show map dots with free docks when user is in landscape while o…
4e1cfd7 
…n trip
@afonsosousah
fix: only recommend fullscreen in devices it is available and only sh…
e91e495 
…ow rotate screen notice when user is in wrong orientation
@afonsosousah
fix: fixed wrong dockRatio calculation, removed useless stop button a…
b85a070 
…nd automatically exit navigation UI when back to portrait
@afonsosousah
fix: exit fullscreen when back to portrait
3c4ecdd
@afonsosousah
feat: follow user position when on trip and navigation UI
ced4c30
@afonsosousah
fixes: added safe area insets, fixed rotation with compass, navigatio…
b062cec 
…n UI improvements
@afonsosousah
fix: change to available docks map dots instantly after starting trip
e022063
@afonsosousah
fix: fixed available docks numbering, improved on trip navigation UI
51058dc
@afonsosousah
fix: changed default speed on nav info panel to 0
e4861a5
@afonsosousah
fix: fixed statistics menu on landscape
3909710
@afonsosousah
fix: updated place search menu and improved the display of routes
26128d4
@afonsosousah
fix: improvements to place searching
83c9f7d
@afonsosousah
fix: ordered if statement for map dots
c5f5f1b
@afonsosousah @ImRodry
Apply suggestions from code review
990b50c 
Co-authored-by: Rodrigo Leitão <38259440+ImRodry@users.noreply.github.com>
@afonsosousah
fix: removed repeated conditions
ebc1877
@afonsosousah
fix: faster loading and fixed map dot blinking sometimes
1522096
@afonsosousah
fix: converted compassHeading to same format as gpsHeading
b8c5d13
@afonsosousah
fix: fixed unlock bike card not opening
d516f9a
@afonsosousah
fix: station name and id on wrong position in landscape station card
03f576f
@afonsosousah
Update bikes.js
05ab78a
@afonsosousah
Update bikes.js
81041c1
@afonsosousah
improvements: user is followed by default, unless user interacts with…
3a781ef 
… map, detect when app is coming from background and update location, renamed and aggregated both position and rotation update functions
@afonsosousah
Copy link
Owner Author

rebased

@afonsosousah afonsosousah merged commit c606a8e into main Apr 24, 2024
1 check passed
@afonsosousah afonsosousah deleted the feat/horizontal-support branch April 24, 2024 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ImRodry ImRodry ImRodry requested changes

Assignees

@afonsosousah afonsosousah

Labels
enhancement New feature or request
Projects
mGira
Status: Done
Milestone
v0.0.5
Development

Successfully merging this pull request may close these issues.

feat: navigation UI when on trip and horizontal mode
2 participants
@afonsosousah @ImRodry