Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The size values for the brush don't have an appropriate scale #67

Closed
dmarcos opened this issue Sep 12, 2016 · 1 comment
Closed

The size values for the brush don't have an appropriate scale #67

dmarcos opened this issue Sep 12, 2016 · 1 comment
Assignees

Comments

@dmarcos
Copy link
Member

dmarcos commented Sep 12, 2016

The schema states a min: 0.0 and max: 1.0. The values in the interval all set very big brushes. We have to either introduce a correction factor somewhere in the brush logic or change the schema to reflect a better scale.

@fernandojsg fernandojsg self-assigned this Sep 13, 2016
@fernandojsg
Copy link
Member

I believe we should change the schema to use meters. So we could have a maximum width of ~20/30cms so it should be max: 0.2/0.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants