Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSED] Add "walk" user movement #377

Closed
ngokevin opened this issue Jan 13, 2016 · 6 comments
Closed

[CLOSED] Add "walk" user movement #377

ngokevin opened this issue Jan 13, 2016 · 6 comments

Comments

@ngokevin
Copy link
Member

Issue by jcarpenter
Saturday Aug 22, 2015 at 01:16 GMT
Originally opened as https://github.com/aframevr/aframe-core/issues/6


User can:

  • Walk fwd / backward
  • Run fwd / backward
  • Strafe left, strafe right
  • Jump

Supported input devices:

  • Keyboard support
  • Gamepad support lower priority

Supported customizable attributes (passed as arguments via element attribute?)

  • Run speed
  • Walk speed
  • Jump strength
  • eg <vr-playerWalk runSpeed="20" walkSpeed="10" jumpStrength="1"></vr-playerWalk>

Need to decide how we want to implement this. For example:

  • Import JS
  • Import JS and create child node within scene

TODO: need to investigate effective player walking controls for virtual reality. Animated pseudo head-bobbing is a big no-no, for example.

@ngokevin
Copy link
Member Author

Comment by jcarpenter
Saturday Aug 29, 2015 at 01:21 GMT


Initial implementation is in place and working well. @caseyyee is looking at optimizing the VR mode version of the controls to better fit the ergonomics of VR.

@ngokevin
Copy link
Member Author

Comment by dmarcos
Thursday Sep 03, 2015 at 18:01 GMT


Can we close this?

@ngokevin
Copy link
Member Author

Comment by caseyyee
Thursday Sep 03, 2015 at 18:19 GMT


Not yet @dmarcos,
So far we only have:

  • walk fwd/back
  • strafe left/right

There is still a bunch of these requirements that still need to be finished yet.

@ngokevin
Copy link
Member Author

Comment by caseyyee
Tuesday Nov 10, 2015 at 19:42 GMT


Part of ngokevin/aframe-core#365 if we decide to merge

@ngokevin
Copy link
Member Author

Comment by sirkitree
Thursday Dec 17, 2015 at 19:17 GMT


#365 was closed in favor of #379 which has been merged.

I don't see any extra functionality though, just how it's defined as an attribute (but I'm just starting to understand the code) so it would seem we still only have walk and strafe.

@ngokevin
Copy link
Member Author

Comment by caseyyee
Thursday Dec 17, 2015 at 19:25 GMT


We can close this for now and file the other inputs as separate issues.
Jump will also require some thought since this could be part of a physics implementation. Also another issue.

@dmarcos dmarcos closed this as completed Jan 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants