Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Search bar not working (no results for anything) #5322

Open
turbotimon opened this issue Jun 26, 2023 · 9 comments
Open

Docs: Search bar not working (no results for anything) #5322

turbotimon opened this issue Jun 26, 2023 · 9 comments

Comments

@turbotimon
Copy link
Contributor

Description:

In the documentation the search bar does not show results for anything. This has been the case for at least a week and has been tested with several browsers:

image

@dmarcos
Copy link
Member

dmarcos commented Jun 30, 2023

Algolia integration is broken at the moment. Can use older versions search for now as a workaround https://aframe.io/docs/1.3.0/introduction/

Sorry for the inconvenience.

@vincentfretin
Copy link
Contributor

@msub2
Copy link
Contributor

msub2 commented Jul 29, 2023

Is there anything we can do to help with this? Or is the Algolia integration something you're managing specifically

@dmarcos
Copy link
Member

dmarcos commented Jul 30, 2023

This is an algolia issue. algolia at some point deprecated the old API and moved to a new one. Indexation of new pages stopped. that's why search of old versions of a-frame still work. Any help appreciated but requires both work on the front end and Algolia side. Anyone can play with the site locally just by replacing the apiKey.

@msub2
Copy link
Contributor

msub2 commented Jul 30, 2023

Interesting, I'll see if I can take a look soon

@dmarcos
Copy link
Member

dmarcos commented Jul 30, 2023

In short if it was not clear. We need to move A-Frame website to the new Algolia API. The old one no longer indexes new pages. This is the file to look at first: https://github.com/aframevr/aframe-site/blob/master/themes/aframe/layout/partials/search.ejs

@msub2
Copy link
Contributor

msub2 commented Jul 30, 2023

It seems as though the new version of docsearch wants you to apply (and wants to verify you are the owner of the docs being indexed among other things) https://docsearch.algolia.com/apply/. Don't know if you've already seen this @dmarcos. Looks like under the hood it's using their Algolia Crawler which doesn't have the same restriction though.

@lainshiHenry
Copy link
Contributor

It seems as though the new version of docsearch wants you to apply (and wants to verify you are the owner of the docs being indexed among other things) https://docsearch.algolia.com/apply/. Don't know if you've already seen this @dmarcos. Looks like under the hood it's using their Algolia Crawler which doesn't have the same restriction though.

As long as the owner enables permissions to update, that sound work too.

"You must be the owner of the website, or at least have the permissions to update its content." (https://docsearch.algolia.com/docs/who-can-apply)

@dmarcos
Copy link
Member

dmarcos commented Jul 30, 2023

You can develop locally with your own account and api key (free). I already did the application. Just haven’t had the time to migrate to the new API / infrastructure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants