[CLOSED] make segment-related geometry attribute names consistent

[ngokevin]

Issue by ngokevin
Monday Nov 09, 2015 at 21:57 GMT
Originally opened as https://github.com/aframevr/aframe-core/issues/396

---

Currently, we have segmentsWidth, segmentsHeight, segmentsRadius, tubularSegments.

We should just follow three.js naming. "segmentsWidth" and "segmentsHeight" are misnomers anyways because they don't denote the width or height of the segments, they denote the number of X segments and Y segments.

[ngokevin]

Comment by cvan
Tuesday Nov 10, 2015 at 02:37 GMT

---

I tried to make this consistent in #316

[ngokevin]

Comment by dmarcos
Saturday Nov 28, 2015 at 07:11 GMT

---

@ngokevin Can we close this?

[ngokevin]

Comment by cvan
Sunday Nov 29, 2015 at 04:24 GMT

---

it's still an issue though: ngokevin/aframe-core@628597#commitcomment-14288096

I'd rather keep this open and arrive at a solution

[ngokevin]

Comment by ngokevin
Monday Nov 30, 2015 at 22:05 GMT

---

Yeah, this isn't addressed. I prefer we follow three.js naming such that our parameter names are consistent with theirs (e.g., use widthSegments rather than segmentsWidth).