Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raycaster returns a-entity instead of templated element #641

Closed
ngokevin opened this issue Jan 13, 2016 · 4 comments
Closed

Raycaster returns a-entity instead of templated element #641

ngokevin opened this issue Jan 13, 2016 · 4 comments

Comments

@ngokevin
Copy link
Member

Issue by caseyyee
Monday Nov 16, 2015 at 21:41 GMT
Originally opened as https://github.com/aframevr/aframe-core/issues/452


Not sure what the proper behavior is, but It would be useful to have the option of returning the parent template element?

@ngokevin
Copy link
Member Author

Comment by caseyyee
Thursday Nov 19, 2015 at 04:52 GMT


Raycaster also returns distance from the geometry face or BB (not sure which one) that is intersected with -- not the objects origin. Again, unsure what the proper behaviour should be here.

@ngokevin
Copy link
Member Author

Comment by cvan
Wednesday Dec 02, 2015 at 08:13 GMT


yeah, this is filed as #204. your issue is more explicit and descriptive of the issue though. a PR has been opened to "fix" this: ngokevin/aframe-core#521

this evening @dmarcos and I discussed all the possible use cases, expected behaviors, caveats, and possible solutions to remedy this. we basically have templates that wrap single elements (entities), and we have templates that wrap multiple elements (entities). the events should be bubbling, but I think it's because the cursor code that sets the hovered state on the <a-entity> itself and not its parent template instance (<a-cube>). @dmarcos and I have to have some more discussions here, but yeah.

@ngokevin
Copy link
Member Author

Comment by jcarpenter
Friday Dec 11, 2015 at 09:51 GMT


Updated title to reflect new naming.

@cvan
Copy link
Contributor

cvan commented Feb 6, 2016

fixed by PR #883. may be an issue again if we resurrect templates (issue #930).

@cvan cvan closed this as completed Feb 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants