Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

disproportional vertical scroll when zoomed in #112

Closed
asnav opened this issue Mar 11, 2024 · 6 comments
Closed

disproportional vertical scroll when zoomed in #112

asnav opened this issue Mar 11, 2024 · 6 comments
Labels
bug Something isn't working Fixed Scheduled to release

Comments

@asnav
Copy link

asnav commented Mar 11, 2024

馃摑 Describe the Bug:
while zoomed in vertical scroll is disproportional, horizontal scroll works just fine which means zoom is taken into account.
i assume there is an extra pan behavior on top of the basic scroll function which makes it too fast.

馃摉 Library Version: 2.0.7

馃毝 Steps to Reproduce:
Please follow these steps to reproduce the issue:

  1. load a pdf file
  2. zoom in
  3. scroll up or down
  4. notice that the view moves faster than your finger

馃 Expected Behavior:
the view should move along with he pointer (your finger) at the same speed

@asnav asnav added the bug Something isn't working label Mar 11, 2024
Copy link

Thank you for creating your first issue. We appreciate your help in making this project better. We will look into it, and get back to you soon. Need help or want to discuss this issue? Join our Discord community here to ask questions and discuss this issue live!

@mlilienberg
Copy link

When google started with instant apps i also implemented a library with a similar approach like this. We use it in production without changes since 2019. This library is published and maintained by a former colleague of mine, you find it here: https://github.com/Dmitry-Borodin/pdfview-android.

I do not want to advertise that library but maybe you can find any technics to improve this one. I was looking into an alternative that is still maintained and has a compose API, but with some weakness like the disproportional scrolling when zoomed I can not use it as a replacement.

So what is the difference? The other library uses a slightly modified clone of subsampling scale imageview to have following benefits:

  • Sharp rendering in any zoom level (especially for text and vector drawings)
  • Only render the visible rect, so that it can handle documents with thousands of pages without delay or memory issues
  • Proportional scroll at any zoom level

Maybe it is possible to merge the concepts of those two libraries.

@Sasikumars41
Copy link

馃摑 Describe the Bug: while zoomed in vertical scroll is disproportional, horizontal scroll works just fine which means zoom is taken into account. i assume there is an extra pan behavior on top of the basic scroll function which makes it too fast.

馃摉 Library Version: 2.0.7

馃毝 Steps to Reproduce: Please follow these steps to reproduce the issue:

  1. load a pdf file
  2. zoom in
  3. scroll up or down
  4. notice that the view moves faster than your finger

馃 Expected Behavior: the view should move along with he pointer (your finger) at the same speed

Scrolling on vertical is not smooth as horizontal scroll after zoom.

@afreakyelf afreakyelf added the Fixed Scheduled to release label Apr 1, 2024
@afreakyelf
Copy link
Owner

Hi, The Above issue has been fixed in new release. https://github.com/afreakyelf/Pdf-Viewer/releases/tag/v2.1.0

Please migrate to Maven central. More here: https://github.com/afreakyelf/Pdf-Viewer/releases/tag/v2.1.0

Thank you for using the library. Please reopen/raise a new issue if you still face this error.

Join our discord for more updates!

@Sasikumars41
Copy link

Hi,

Please slow down the scrolling speed of the scroll after zoom. It works fine on normal state.

@asnav
Copy link
Author

asnav commented Apr 17, 2024

It has indeed not been fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Fixed Scheduled to release
Projects
None yet
Development

No branches or pull requests

4 participants