Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the Inventory graph #6029

Open
rdstern opened this issue Oct 19, 2020 · 13 comments
Open

Improving the Inventory graph #6029

rdstern opened this issue Oct 19, 2020 · 13 comments
Assignees
Labels
Milestone

Comments

@rdstern
Copy link
Collaborator

rdstern commented Oct 19, 2020

image

It would be good to enhance different aspects of this graph. It is a function and hence I suggest these be added as a sub-dialogue.
There are a number of elements to add and that is for daily data. It would also be good if it could work better for hourly data.
Among the additions would be:
a) Key position and particularly an option to not have a key.
b) Options for the display on the right - perhaps (at least) being able to have the labels at 90 degrees. Also edits on the size would be useful.
c) I wonder if we still need the option on rain.
d) There could be title, sub-title and footnote, as for the PICSA rainfall graphs.
e) Could the x-axis have flexibility in the number of points used.
f) Delete Years as the x-axis name. It isn't needed.
g) Options for size of display on left, and perhaps also for number of points. Possibly no display as an option?
h) Do we want options on colours?

The items will need discussion, before being implemented. I hope @dannyparsons and @shadrackkibet can advise

@rdstern rdstern added this to the 0.6.x milestone Oct 19, 2020
@N-thony
Copy link
Collaborator

N-thony commented Nov 2, 2020

image

@N-thony
Copy link
Collaborator

N-thony commented Nov 2, 2020

image

@N-thony
Copy link
Collaborator

N-thony commented Nov 2, 2020

image

@N-thony
Copy link
Collaborator

N-thony commented Nov 2, 2020

image

@N-thony
Copy link
Collaborator

N-thony commented Nov 2, 2020

image

@N-thony
Copy link
Collaborator

N-thony commented Nov 2, 2020

@Roger, I have made the design for the inventory sub dialog to improve the inventory graph.

@rdstern
Copy link
Collaborator Author

rdstern commented Nov 2, 2020

@N-thony many thanks for this. Overall it looks good, and I wonder if you have made parallel progress with new arguments in the function. Then different aspects could then be tried as the sub-dialogues are progressively implemented. They can be tested using rstudio or through the script window.
This does now also need input from @dannyparsons as well. Here are some comments. They are based on the graph at the top, which has the time of year as the facets, but the facet labels cannot be read. There should be more examples to be improved.
a) How does your system cope with the facet labels? I wonder if there should be an option for not labelling the facets in the situation above, where they are the months, but too small to see?
b) In the same situation, the label on the right has 2 parts, namely station and element. I am not sure what the options are in ggplot to make this more legible. Nor how this relates to your y-axis labels options.
c) You have a tab for themes, though it only has the legend. This could be changed to Legend.
d) The colours is not included in your suggestions. Might there be a themes tab instead, that would include a variety of display colours, or would that complicate the function, because it would affect other aspects of the graph?

@rdstern
Copy link
Collaborator Author

rdstern commented Jan 25, 2021

@N-thony in the previous version, when there were 2 factors, station and element, the facets were in a single column. Now we can have either station as the column and element as the row. Or the opposite. But sometimes I would like then all vertical - as before. I don't now seem to be able to get that option. Is there a setting I am missing? If not, then could that option be re-instated?

By the way, I tried the fixed number of rows in the sub-dialogue. I made it 12 but it ignores me and is always reset when I return to the dialogue again.

@N-thony
Copy link
Collaborator

N-thony commented Jan 25, 2021

@N-thony in the previous version, when there were 2 factors, station and element, the facets were in a single column. Now we can have either station as the column and element as the row. Or the opposite. But sometimes I would like then all vertical - as before. I don't now seem to be able to get that option. Is there a setting I am missing? If not, then could that option be re-instated?

By the way, I tried the fixed number of rows in the sub-dialogue. I made it 12 but it ignores me and is always reset when I return to the dialogue again.
@rdstern Is it this you were looking for?
image

@rdstern
Copy link
Collaborator Author

rdstern commented Jan 25, 2021

The other way round. That's 4 columns and 1 row. With 2 stations and 2 elements I would like 4 rows and one column

@N-thony
Copy link
Collaborator

N-thony commented Jan 25, 2021

The other way round. That's 4 columns and 1 row. With 2 stations and 2 elements I would like 4 rows and one column
@rdstern This one?
image

@rdstern
Copy link
Collaborator Author

rdstern commented Jan 25, 2021

Correct. How did you get this?

@N-thony
Copy link
Collaborator

N-thony commented Jan 25, 2021

Correct. How did you get this?

I think I have changed the code a bit. You would like this to be back as before?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

No branches or pull requests

2 participants