New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvements to Stack(Pivot Longer) dialog #6876
Conversation
Updating Master
Update Master
Updating Master
Updating Master
@N-thony Please could you do the first peer review? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the fact this now has new features from the pivot_longer function.
But I assume that the old feature of being able to stack multiple sets is still to be re-instated? I would be happy for it to be done "in the old way" so it doesn't necessarily use pivot_longer. I suggest we only use the tidyverse functions when they are convenient. It isn't a rule.
This feature is going to be reinstated on this PR. I did discuss it with @Vitalis95 so we will soon have it ready for testing. |
@shadrackkibet, have a look at it. |
@Vitalis95 Please could you resolve @N-thony 's comment above? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vitalis95 to me this looks fine now. Let's see what @shadrackkibet thinks?
@N-thony , I have made the alignments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vitalis95 Thanks, this looks good, just a few suggestions
Co-authored-by: lloyddewit <57253949+lloyddewit@users.noreply.github.com>
@lloyddewit I have made the changes. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Vitalis95 thanks, looks good
@rdstern there's been some small changes since your last approval, please could you retest? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Partially solves #6868
@rdstern @shadrackkibet, this is for the Drop Missing Values Checkbox. Have a look at it.