Combined the three plot options buttons in Climatic Maps #7481
Conversation
instat/dlgClimaticStationMaps.vb
Outdated
| @@ -235,7 +235,7 @@ Public Class dlgClimaticStationMaps | |||
| AutoFillGeometry() | |||
| End Sub | |||
|
|
|||
| Private Sub cmdPlotOptions_Click(sender As Object, e As EventArgs) Handles cmdPlotOptions.Click | |||
| Private Sub cmdPlotOptions_Click(sender As Object, e As EventArgs) | |||
There was a problem hiding this comment.
Out of interest, now that these do not have the "Handles ...", what does this Sub do?
There was a problem hiding this comment.
And the other cmd*Options_Click subs
instat/dlgClimaticStationMaps.vb
Outdated
| @@ -235,7 +235,7 @@ Public Class dlgClimaticStationMaps | |||
| AutoFillGeometry() | |||
| End Sub | |||
|
|
|||
| Private Sub cmdPlotOptions_Click(sender As Object, e As EventArgs) Handles cmdPlotOptions.Click | |||
| Private Sub cmdPlotOptions_Click(sender As Object, e As EventArgs) | |||
There was a problem hiding this comment.
If this function does not handle any event(s), then it will never be called.
Delete this function?
|
@lilyclements I think we reviewed in parallel and came up with the same comment! |
@lloyddewit @lilyclements I resolved your comments? :) |
@N-thony please can you also resolve my first comment ( |
@lloyddewit I resolved your last comment. |
|
@rdstern if you can test/approve, then we can merge, thanks |
|
@shadrackkibet can you test/merge this? |
|
I don't think I have privileges to merge PRs again. I think the process of merging PRs might have changed? |
Okay, I will check with @ChrisMarsh82, thanks. |
Fixes #7472
@africanmathsinitiative/developers this is ready for review.
@rdstern @lilyclements could you test this?