Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed the defaults of Correlation dialog to be '2/3 Variables' or 'Multivariate' depending on menu option used to open dialog #7536

Merged
merged 5 commits into from Jun 9, 2022

Conversation

Vitalis95
Copy link
Contributor

Fixes #7452
It replaces PR #7457 due to conflicting files
@rdstern @N-thony @lloyddewit this PR makes default to be Multiple variables in Multivariate sub-menu and Two Variables in 2/3 variables sub-menu
I have also updated the database for the labels changed

image

Copy link
Collaborator

@rdstern rdstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

Copy link
Contributor

@lloyddewit lloyddewit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vitalis95 Looks very good, I liked your use of Enum. Thanks also for clearly documenting the database changes.

@lloyddewit lloyddewit changed the title Changed the defaults of correlation dialog in Multivariate and 2/3 Variables sub-menus Changed the defaults of Correlation dialog to be '2/3 Variables' or 'Multivariate' depending on menu option used to open dialog Jun 9, 2022
@lloyddewit lloyddewit merged commit df44d53 into IDEMSInternational:master Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In Correlation dialog, Make Two variables default in 2/3 Variables and Multiple variables in Multivariate
3 participants